pymc-devs / pymc-resources

PyMC educational resources
MIT License
1.96k stars 745 forks source link

Fixed an issue with `m4_3b` model which returned a negative b-value not consistent with output from textbook #230

Open vanislekahuna opened 1 year ago

vanislekahuna commented 1 year ago

The previous m4_3b model resulted in a negative $\beta$-value which isn't consistent with what's in Prof. McElreath's "Statistical Rethinking" textbook. I've written a line of code to properly generate a log-normal distribution for the $\beta$-value so that it results in a positive value (i.e. roughly 0.902) when you return the summary table for trace_4_3b. I'm planning to submit more PR's as I read through the text so any good feedback for my first PR would be helpful!

Thank you for opening a pull request!

Please check our style guide, and also make sure that the notebooks you've modified pass the pre-commit checks. If, for example, you modified notebook1.ipynb and notebook2.ipynb, you could do this by running:

pre-commit run --files notebook1.ipynb notebook2.ipynb

You may need to run it a couple of times before all the checks pass.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB