search

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.71k stars 2.01k forks source link

Add Type Hints to distribution parameters #5358

Open canyon289 opened 2 years ago

canyon289 commented 2 years ago

Add type hints to distribution parameters as demonstrated by this PR. https://github.com/pymc-devs/pymc/pull/5315

If multiple people are interested in this we split this up by module

nvasilevv commented 2 years ago

Hi @canyon289, if you do not mind, I can pick that?

canyon289 commented 2 years ago

@nvasilevv sure thing! Do you know which file(s) you want to start with? I'll open up a subissue for you so this can be address in parts

nvasilevv commented 2 years ago

Well, I do not have preferences. I have a brief question on #5315. I saw that no type hints were used here. Any reason why this is the case? There are other instances within the file where such changes were skipped, but looks like such are possible. Was this out of the scope of the PR or is there something I am missing? Thanks

mjhajharia commented 2 years ago

hi @nvasilevv, thanks for volunteering to contribute! did you open a pull request? if not, can you choose a submodule so we can create more issues and split up the work, it would be easier for you to contribute and us to manage the workflow that way! let me know if you need help

nvasilevv commented 2 years ago

Hi @mjhajharia, sorry for the late reply. I can start with the discrete distributions if that is ok with everyone.

canyon289 commented 2 years ago

@nvasilevv discrete distributions sounds great. I'll add a note to the issue to indicate your assignment. Thanks for your continued interest

purna135 commented 2 years ago

Hello, I'd like to work on this but don't know where to begin; could you possibly point me in the right direction? Thanks

hectormz commented 2 years ago

@canyon289 @mjhajharia I was looking through what remains to be done for this. Are you trying to update the type hints for all def dist() with current types of:

?

canyon289 commented 2 years ago

hey hector, all the ones that are applicable!

soma2000-lang commented 1 year ago

@canyon289 Working on the mixture

iykat commented 1 year ago

@canyon289 working on continuous.

canyon289 commented 1 year ago

Thanks!

johanbog commented 1 year ago

As the PR for discrete distributions was never merged, I'm picking that up now.

fergur commented 4 months ago

I'll take a look at this one. (hackathon)