Move slightly duplicated RVs to PyTensor

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python

https://docs.pymc.io/

Other

8.67k stars 2k forks source link

Move slightly duplicated RVs to PyTensor #6479

Open ricardoV94 opened 1 year ago

ricardoV94 commented 1 year ago

Description

We have a few RVs implemented in PyMC with similar (or simply duplicated) forms in PyTensor. We should move those there / remove to avoid the code duplication.

WaldRV (extra param)
BetaClippedRV (small change in perform)
StudentTRV (duplicated)
WeibullBetaRV (extra param)

yashvmanmode commented 1 year ago

Hi @ricardoV94

I am Yash Manmode. I am a beginner in Open source Contribution. can you please give more details on this issue so that I can contribute to this issue.

thank You

jiisa-k commented 1 year ago

Hi @ricardoV94! If I understand correctly, these RVs have been implemented in PyMC and a similar or the same version has been implemented in PyTensor. Would you prefer moving those there and removing the implementation in PyMC or directly removing these implementations from PyMC?