pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.68k stars 2.01k forks source link

Upgrade to ruff 0.2.0 and fix RUF017 #7129

Closed Armavica closed 8 months ago

Armavica commented 8 months ago

Description

Related Issue

Checklist

Type of change


πŸ“š Documentation preview πŸ“š: https://pymc--7129.org.readthedocs.build/en/7129/

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (94020c9) 90.17% compared to head (70de7e2) 90.17%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7129/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7129 +/- ## ======================================= Coverage 90.17% 90.17% ======================================= Files 101 101 Lines 16932 16933 +1 ======================================= + Hits 15269 15270 +1 Misses 1663 1663 ``` | [Files](https://app.codecov.io/gh/pymc-devs/pymc/pull/7129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) | Coverage Ξ” | | |---|---|---| | [pymc/logprob/scan.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9sb2dwcm9iL3NjYW4ucHk=) | `97.52% <100.00%> (ΓΈ)` | | | [pymc/variational/opvi.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy92YXJpYXRpb25hbC9vcHZpLnB5) | `74.06% <100.00%> (ΓΈ)` | | | [pymc/backends/report.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9iYWNrZW5kcy9yZXBvcnQucHk=) | `79.24% <50.00%> (+0.39%)` | :arrow_up: |
Armavica commented 8 months ago

It looks like this test failure is unrelated to these changes, as it already occurs in main.

maresb commented 8 months ago

Hmm...

FAILED tests/variational/test_inference.py::test_fit_start[SVGD-mini] - Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) were emitted.
 Emitted warnings: [].
ricardoV94 commented 8 months ago

Hmm...

FAILED tests/variational/test_inference.py::test_fit_start[SVGD-mini] - Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) were emitted.
 Emitted warnings: [].

it's failing everywhere I'll check Monday