pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python

https://docs.pymc.io/

Other

8.62k stars 1.99k forks source link

pre-commit not always running in CI when it should #7131

Closed maresb closed 7 months ago

maresb commented 7 months ago

Description

7108 deleted the EOF newline in `requirements-dev.txt`. After merge that broke pre-commit checks on `main`. There were no errors raised in the CI checks in #7108.

ricardoV94 commented 7 months ago

Did that PR actually run with the new CI?

maresb commented 7 months ago

Oh, that's a really good point, it ran with neither the new nor the old. Unfortunately I only had a few minutes to look into why, and I didn't see anything at first glance, hence this issue instead of a solution in a PR.

Maybe it was just some glitch? I'll do a quick test...

maresb commented 7 months ago

My test in #7140 suggests that this was a glitch. I'll close, but we should keep an eye on it.

pymc-devs / pymc

pre-commit not always running in CI when it should #7131

Description

7108 deleted the EOF newline in requirements-dev.txt. After merge that broke pre-commit checks on main. There were no errors raised in the CI checks in #7108.

7108 deleted the EOF newline in `requirements-dev.txt`. After merge that broke pre-commit checks on `main`. There were no errors raised in the CI checks in #7108.