Deprecate `block_diag` from math module in favor of PyTensor

[AryanNanda17]

The new code uses the sparse parameter to determine whether to call the sparse block_diag function (pytensor.sparse.basic.block_diag) or the dense version (pt.slinalg.block_diag).

Related Issue

• [x] Closes #7085

Checklist

• [x] Checked that the pre-commit linting/style checks pass
• [x] Added necessary documentation (docstrings and/or example notebooks)
• [x] If you are a pro: each commit corresponds to a relevant logical change

Type of change

• [x] New feature/enhancement
• [ ] Bug fix
• [ ] Documentation
• [ ] Maintenance
• [ ] Other (please specify):

---

📚 Documentation preview 📚: https://pymc--7132.org.readthedocs.build/en/7132/

[AryanNanda17]

@larryshamalama, @ricardoV94, and @jessegrabowski please look into the PR and suggest if any changes are required.

[codecov[bot]]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (94020c9) 90.17% compared to head (fe8a065) 39.96%. Report is 12 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/pymc-devs/pymc/pull/7132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7132 +/- ## =========================================== - Coverage 90.17% 39.96% -50.21% =========================================== Files 101 101 Lines 16932 16928 -4 =========================================== - Hits 15269 6766 -8503 - Misses 1663 10162 +8499 ``` | [Files](https://app.codecov.io/gh/pymc-devs/pymc/pull/7132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) | Coverage Δ | | |---|---|---| | [pymc/math.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9tYXRoLnB5) | `30.00% <20.00%> (-39.16%)` | :arrow_down: | ... and [81 files with indirect coverage changes](https://app.codecov.io/gh/pymc-devs/pymc/pull/7132/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)

[AryanNanda17]

What am I doing wrong here, the Codecov/patch test failed?

[ricardoV94]

@AryanNanda17 I asked the person commenting earlier on the original issue if they would be interested in working on this issue as a courtesy. If you see an issue you would like to work on where someone else seemed to be interested recently please confirm with them first if they are happy to let you take over.

Our official policy is opening a PR first is what counts, but for these small non critical issues we would like to give room for everyone to have their first chance. There are many harder issues that we need help with for which there's no risk of multiple people being interested at the same time.

[AryanNanda17]

@ricardoV94, Can You suggest some harder issues? It would be my first hard issue so I am not sure which one to start with.

[ricardoV94]

@AryanNanda17

These beginner friendly ones don't seem to have anyone interested and may be good?

• https://github.com/pymc-devs/pymc/issues/6985
• https://github.com/pymc-devs/pymc/issues/6686 (there's a stale PR, fine to take over)

We also have many good issue in the related repos: PyTensor and PyMC-Experimental that tend to fall more out of the radar:

• https://github.com/pymc-devs/pymc-experimental
• https://github.com/pymc-devs/pytensor/issues?q=is%3Aopen+is%3Aissue+label%3A%22beginner+friendly%22

[AryanNanda17]

@ricardoV94, I made the changes please checkout.

[AryanNanda17]

Thanks for looking into the issue @ricardoV94.

[ricardoV94]

Thanks @AryanNanda17