pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.62k stars 1.99k forks source link

added icdf for asymmetric laplace distribution #7141

Closed ParamThakkar123 closed 5 months ago

ParamThakkar123 commented 7 months ago

Description

Added icdf function for Asymmetric Laplace distribution

Related Issue

Checklist

Type of change


📚 Documentation preview 📚: https://pymc--7141.org.readthedocs.build/en/7141/

ParamThakkar123 commented 7 months ago

@larryshamalama please take a look at my pull request

ParamThakkar123 commented 7 months ago

Are there any changes needed to be done ?

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7bb2ccd) 92.21% compared to head (17338f6) 71.34%. Report is 31 commits behind head on main.

:exclamation: Current head 17338f6 differs from pull request most recent head bb312a8. Consider uploading reports for the commit bb312a8 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7141/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7141 +/- ## =========================================== - Coverage 92.21% 71.34% -20.87% =========================================== Files 101 101 Lines 16912 16967 +55 =========================================== - Hits 15595 12105 -3490 - Misses 1317 4862 +3545 ``` | [Files](https://app.codecov.io/gh/pymc-devs/pymc/pull/7141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) | Coverage Δ | | |---|---|---| | [pymc/distributions/continuous.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9kaXN0cmlidXRpb25zL2NvbnRpbnVvdXMucHk=) | `64.36% <50.00%> (-33.43%)` | :arrow_down: | ... and [82 files with indirect coverage changes](https://app.codecov.io/gh/pymc-devs/pymc/pull/7141/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)
ParamThakkar123 commented 7 months ago

@larryshamalama I made the changes.

larryshamalama commented 7 months ago

Have you checked if the test passes locally? That would be an indication, good or bad, if you are on the right track

ParamThakkar123 commented 6 months ago

@ricardoV94 I changed the if else conditions in python to pytensor condition