pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.68k stars 2.01k forks source link

Fix failing VI test due to pytest change #7144

Closed aerubanov closed 8 months ago

aerubanov commented 8 months ago

Description

In pytest 7 missing warning were ignored if some exception was raised, but pytest 8 checking them and thats why test_fit_start[SVGD-mini] fails. I replaced pytest.warn() by manual check for warning raised.

Related Issue

Type of change


📚 Documentation preview 📚: https://pymc--7144.org.readthedocs.build/en/7144/

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4991b6a) 58.65% compared to head (9826bd1) 92.25%. Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7144/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7144 +/- ## =========================================== + Coverage 58.65% 92.25% +33.59% =========================================== Files 101 101 Lines 16961 16961 =========================================== + Hits 9949 15647 +5698 + Misses 7012 1314 -5698 ``` [see 71 files with indirect coverage changes](https://app.codecov.io/gh/pymc-devs/pymc/pull/7144/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)
ferrine commented 8 months ago

Many thanks investigating that!

ricardoV94 commented 8 months ago

Thanks a ton @aerubanov!