search

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.53k stars 1.98k forks source link

Fix copying of shared variables in `fgraph_from_model` #7153

Closed ricardoV94 closed 5 months ago

ricardoV94 commented 5 months ago

Closes #7105

Also removes use of deprecated ScalarSharedVariable class https://github.com/pymc-devs/pytensor/pull/629

πŸ“š Documentation preview πŸ“š: https://pymc--7153.org.readthedocs.build/en/7153/

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (627a8dd) 90.41% compared to head (52b6106) 92.36%. Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7153/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7153 +/- ## ========================================== + Coverage 90.41% 92.36% +1.94% ========================================== Files 101 101 Lines 16930 16929 -1 ========================================== + Hits 15308 15636 +328 + Misses 1622 1293 -329 ``` | [Files](https://app.codecov.io/gh/pymc-devs/pymc/pull/7153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) | Coverage Ξ” | | |---|---|---| | [pymc/model/core.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9tb2RlbC9jb3JlLnB5) | `92.22% <100.00%> (ΓΈ)` | | | [pymc/model/fgraph.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9tb2RlbC9mZ3JhcGgucHk=) | `97.39% <100.00%> (-0.02%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/pymc-devs/pymc/pull/7153/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)