Closed aerubanov closed 5 months ago
]
:tada: Welcome to PyMC! :tada: We're really excited to have your input into the project! :sparkling_heart:
If you haven't done so already, please make sure you check out our Contributing Guidelines and Code of Conduct.
May be connected to https://github.com/pymc-devs/pymc/pull/7114
@aerubanov can you see if the pytensor.dprint changes across runs/when it fails (other than the RNG variable)
@ricardoV94 pytensor.dprint(y)
output for passed test
uniform_rv{0, (0, 0), floatX, False}.1 [id A] 'y'
├─ RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7F7B3A7F8BA0>) [id B]
├─ [] [id C]
├─ 11 [id D]
├─ Neg [id E]
│ └─ x [id F]
└─ halfnormal_rv{0, (0, 0), floatX, False}.1 [id G] 'x'
├─ RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7F7B3A7F8040>) [id H]
├─ [] [id I]
├─ 11 [id J]
├─ 0.0 [id K]
└─ 0.001 [id L]
and for failed one
uniform_rv{0, (0, 0), floatX, False}.1 [id A] 'y'
├─ RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7FC7DE640E40>) [id B]
├─ [] [id C]
├─ 11 [id D]
├─ Neg [id E]
│ └─ x [id F]
└─ halfnormal_rv{0, (0, 0), floatX, False}.1 [id G] 'x'
├─ RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7FC7DE35F5A0>) [id H]
├─ [] [id I]
├─ 11 [id J]
├─ 0.0 [id K]
└─ 0.001 [id L]
Looks same for me
Yeah. Is the failure reasonable under random variation?
Y should be U(0, x)?. Something is off about the test but I don't remember the idea
I guess the idea was that by increasing the scale it's unlikely a draw would be in the -1, 1 range, but that's still 1%. We could make it -10_000, 10_000 range instead, and add a comment that it should fail 1/10_000 of the times
Describe the issue:
test_replace_vars_in_graphs_nested_reference
intests/test_pytensorf.py
fails sometimes (1 of 50 approx) both locally and in CI github action (like here https://github.com/pymc-devs/pymc/actions/runs/8005225256/job/21864183620)Reproduceable code example:
Error message:
PyMC version information:
pymc: main brunch on
74748c71ff0
pytensor: 2.18.6 os: linux (manjaro)Context for the issue:
No response