Closed tvwenger closed 7 months ago
@ricardoV94 other branch got mucked up during upstream rebase, so I closed that PR in favor of this one. It's ready for review when the checks are complete.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.26%. Comparing base (
47f6d9e
) to head (dfec0af
).
I had to revert the behavior for negative tau
since it broke other tests.
@ricardoV94 Ready to merge
Thanks @tvwenger
What is this PR about? This PR refactors the
get_tau_sigma
logic in order to support lists ofVariable
s and fixes https://github.com/pymc-devs/pymc/issues/6987.N.B. The original code had a positivity check for non-
Variable
arguments, but not forVariable
arguments. Since this PR casts the arguments toVariable
, I've removed the positivity check for non-Variable
arguments.Resubmission of https://github.com/pymc-devs/pymc/pull/6988
Checklist
Major / Breaking Changes
get_tau_sigma
now always returns aVariable
, even when scalars are passedNew features
Bugfixes
Documentation
Maintenance
π Documentation preview π: https://pymc--7185.org.readthedocs.build/en/7185/