pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.49k stars 1.97k forks source link

Extend `gp.Latent` to multi-outputs #7226

Open hchen19 opened 3 months ago

hchen19 commented 3 months ago

Description

add an argument n_outputs to gp.Latnet class with default value = 1

Related Issue

Checklist

Type of change


📚 Documentation preview 📚: https://pymc--7226.org.readthedocs.build/en/7226/

welcome[bot] commented 3 months ago

Thank You Banner] :sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

bwengals commented 3 months ago

thanks for picking this up!

bwengals commented 3 months ago

This is looking good, though I still need to check out your branch and make sure. It looks like pre-commit isn't happy though. This page should show you how to fix it. Once that's green we can trigger the tests.

hchen19 commented 3 months ago

This is looking good, though I still need to check out your branch and make sure. It looks like pre-commit isn't happy though. This page should show you how to fix it. Once that's green we can trigger the tests.

I fixed the pre-commit issue

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.67%. Comparing base (034b9a4) to head (11e41da). Report is 104 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7226/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7226 +/- ## ========================================== - Coverage 92.29% 91.67% -0.62% ========================================== Files 101 102 +1 Lines 16892 21739 +4847 ========================================== + Hits 15590 19930 +4340 - Misses 1302 1809 +507 ``` | [Files](https://app.codecov.io/gh/pymc-devs/pymc/pull/7226?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) | Coverage Δ | | |---|---|---| | [pymc/gp/gp.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7226?src=pr&el=tree&filepath=pymc%2Fgp%2Fgp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9ncC9ncC5weQ==) | `95.07% <100.00%> (+0.03%)` | :arrow_up: | ... and [37 files with indirect coverage changes](https://app.codecov.io/gh/pymc-devs/pymc/pull/7226/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)