Closed mkusnetsov closed 2 months ago
]
:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.
Thanks, @ricardoV94! That's a good point - I pushed some changes to clarify transform
kwarg as distinct from default_transform
.
But I might be doing something wrong? Although I can see the commits and the changes, the preview documentation is still showing the original version, not the revised one... (I know it takes a while to re-build but it seems to be saying "Read the Docs build succeeded!")
But I might be doing something wrong? Although I can see the commits and the changes, the preview documentation is still showing the original version, not the revised one... (I know it takes a while to re-build but it seems to be saying "Read the Docs build succeeded!")
It takes some time for the preview to update. I think it's correct now? https://pymcio--7232.org.readthedocs.build/projects/docs/en/7232/api/distributions/transforms.html
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.30%. Comparing base (
4f6831e
) to head (f29112f
). Report is 2 commits behind head on main.
Thank you for the kind words! It is correct now, yes. Will know that it takes a while, in the future. And yes - it absolutely makes sense to wait for the other PR.
I left some open questions on the underlying issue. Are any of them worth pursuing either in a separate issue or a discussion? Just checking because I assume once that issue is closed they might get lost.
]
Congrats on merging your first pull request! :tada: We here at PyMC are proud of you! :sparkling_heart: Thank you so much for your contribution :gift:
Thanks a ton @mkusnetsov, don't hesitate in opening issues/PRs for other areas you find documentation to be lacking
Description
This PR adds an introduction section to the Transformations API page to:
In addition this PR:
ordered
transform (I think it was accidentally left over from whenunivariate_ordered
was deprecated)SumsTo1
, which is being deprecatedThis PR assumes that the issue #5674 is closed (via PR #7207) to avoid extensive (and somewhat non-intuitive to casual user) guidance that will shortly be outdated
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7232.org.readthedocs.build/en/7232/