Reenable some compiler errors

maresb commented 2 months ago

Ideally we fix issues instead of suppressing them

Description

I'm hoping that https://github.com/pymc-devs/pytensor/pull/725 will make this flag unnecessary. Looking forward to seeing what happens.

Related Issue

[ ] Closes #
[ ] Related to #

Checklist

[ ] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[ ] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Type of change

[ ] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7270.org.readthedocs.build/en/7270/

maresb commented 2 months ago

@ricardoV94, it seems to me like we're missing these upstream macos failures since the PyTensor test suite doesn't run on macos. Any particular reason it's absent? Seems like it would be prudent to add.

ricardoV94 commented 2 months ago

@ricardoV94, it seems to me like we're missing these upstream macos failures since the PyTensor test suite doesn't run on macos. Any particular reason it's absent? Seems like it would be prudent to add.

We have refrained from duplicating the whole test suite across different OSes because it's pretty wasteful. But we can add other OS jobs with targeted tests. The hard part is just picking what to select

pymc-devs / pymc