Add time remaining column to progress bars - Githubissues

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python

https://docs.pymc.io/

Other

8.48k stars 1.97k forks source link

Add time remaining column to progress bars #7273

Closed fonnesbeck closed 2 months ago

fonnesbeck commented 2 months ago

Description

Adds TimeRemainingColumn to progress bar where appropriate, also properly hides progressbar during sample_posterior_predictive

Related Issue

[x] Closes #7269
[x] Closes #7264
[x] Closes #7278

Checklist

[x] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[ ] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Type of change

[x] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7273.org.readthedocs.build/en/7273/

ricardoV94 commented 2 months ago

While we're here can we also try to fix #7264 ?

This issue suggests there should be transient flag we can play with? https://github.com/Textualize/rich/issues/110

fonnesbeck commented 2 months ago

Will try and fix #7278 here as well.

fonnesbeck commented 2 months ago

ricardoV94 commented 2 months ago

Branch seems to have some conflicts?