search

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.48k stars 1.97k forks source link

Add test to compare draws when `var_names` is used in `pm.sample()` #7287

Closed tomicapretto closed 2 months ago

tomicapretto commented 2 months ago

This PR adds a test that complements the bug fix in #7284

It finally closes #7258

📚 Documentation preview 📚: https://pymc--7287.org.readthedocs.build/en/7287/

ricardoV94 commented 2 months ago

You can remove the previous test (the one above), since this covers everything that is tested there. You can reuse the old name that's also shorter

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.33%. Comparing base (a74c03f) to head (538c3a5).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7287/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7287 +/- ## ======================================= Coverage 92.33% 92.33% ======================================= Files 102 102 Lines 17018 17018 ======================================= Hits 15713 15713 Misses 1305 1305 ```