Fix draws of Weibull when alpha and beta implicitly define size

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python

https://docs.pymc.io/

Other

8.48k stars 1.97k forks source link

Fix draws of Weibull when alpha and beta implicitly define size #7288

Closed tomicapretto closed 2 months ago

tomicapretto commented 2 months ago

Description

This PR incorporates the broadcasting of the shapes of alpha and beta in the random value generation method from the Weibull distribution to provide a fix to the problem shown in #7220

Related Issue

Closes #7220

Type of change

[ ] New feature / enhancement
[x] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7288.org.readthedocs.build/en/7288/

ricardoV94 commented 2 months ago

Thanks @tomicapretto, great test although a bit unfair that it only exists for this RV.

That means I'm okay with no regression test here, but I am definitely not against it either

ricardoV94 commented 2 months ago

Thanks @tomicapretto !