Closed markgreene74 closed 1 week ago
]
:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.
Hi @ricardoV94 thank you for all the comments :) I think this PR should be ready for review now, happy for me to change the status?
I rebased the PR on top of main to solve the conflicts with #7370
Attention: Patch coverage is 94.59459%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 92.19%. Comparing base (
e71d1cb
) to head (9da36c3
).
]
Congrats on merging your first pull request! :tada: We here at PyMC are proud of you! :sparkling_heart: Thank you so much for your contribution :gift:
@Hemant19870601 and I worked on this PR during the PyMC Hackathon at PyData London 2024.
Description
With this PR
CustomDist
is moved to a separate file (custom_distribution.py
) along with related classes (CustomDistRV
,CustomDistRV
,CustomSymbolicDistRV
,_CustomSymbolicDist
) and helper functions (default_not_implemented
,default_support_point
).The imports in
distribution.py
and__init__.py
have been updated to reflect the changes.DensityDist
has been moved to the new file as well.Note that in
distribution.py
the import ofCustomSymbolicDistRV
has been added close to where the class is used to avoid circular import. Anoqa
has been added on the same line to avoid aruff
error for the misplaced import (E402
).Similarly, the
CustomDist
tests have been moved to their own file (test_custom_distribution.py
) and are passing.main
branch)test_distribution.py
test_custom_distribution.py
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7363.org.readthedocs.build/en/7363/