Rename `samples` argument to `draws` in `sample_prior_predictive` - Githubissues

pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python

https://docs.pymc.io/

Other

8.47k stars 1.97k forks source link

Rename `samples` argument to `draws` in `sample_prior_predictive` #7366

Closed wd60622 closed 2 weeks ago

wd60622 commented 2 weeks ago

Description

Consolidate with other sampling parameter names

Related Issue

[x] Closes #7173
[ ] Related to #

Checklist

[x] Checked that the pre-commit linting/style checks pass
[x] Included tests that prove the fix is effective or that the new feature works
[x] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Type of change

[ ] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[x] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7366.org.readthedocs.build/en/7366/

wd60622 commented 2 weeks ago

I will switch all samples= in the test suite to draws. It seems to be all over

review-notebook-app[bot] commented 2 weeks ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ricardoV94 commented 2 weeks ago

Super weird codecov upload failures, I presume unrelated

ricardoV94 commented 2 weeks ago

All tests had passed so merged it. Hopefully the codecov thing is just a fluke