pymc-devs / pymc

Bayesian Modeling and Probabilistic Programming in Python
https://docs.pymc.io/
Other
8.47k stars 1.97k forks source link

Assert ndim and number of dims match #7390

Closed ricardoV94 closed 5 days ago

ricardoV94 commented 6 days ago

Fixes bug where invalid number of dims was given to Deterministic introduced by OrderedLogistic/Probit

Description

Related Issue

Checklist

Type of change


📚 Documentation preview 📚: https://pymc--7390.org.readthedocs.build/en/7390/

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.19%. Comparing base (b496127) to head (81f25c1). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pymc-devs/pymc/pull/7390/graphs/tree.svg?width=650&height=150&src=pr&token=JFuXtOJ4Cb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs)](https://app.codecov.io/gh/pymc-devs/pymc/pull/7390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) ```diff @@ Coverage Diff @@ ## main #7390 +/- ## ======================================= Coverage 92.19% 92.19% ======================================= Files 103 103 Lines 17214 17215 +1 ======================================= + Hits 15870 15871 +1 Misses 1344 1344 ``` | [Files](https://app.codecov.io/gh/pymc-devs/pymc/pull/7390?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs) | Coverage Δ | | |---|---|---| | [pymc/distributions/discrete.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7390?src=pr&el=tree&filepath=pymc%2Fdistributions%2Fdiscrete.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9kaXN0cmlidXRpb25zL2Rpc2NyZXRlLnB5) | `99.40% <100.00%> (-0.01%)` | :arrow_down: | | [pymc/model/core.py](https://app.codecov.io/gh/pymc-devs/pymc/pull/7390?src=pr&el=tree&filepath=pymc%2Fmodel%2Fcore.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymc-devs#diff-cHltYy9tb2RlbC9jb3JlLnB5) | `91.77% <100.00%> (+0.02%)` | :arrow_up: |