Don't filter out parameters named 'args' or 'kwd' in utils.get_signature().

pymc-devs / pymc2

THIS IS THE **OLD** PYMC PROJECT (VERSION 2). PLEASE USE PYMC INSTEAD:

http://pymc-devs.github.com/pymc/

Other

879 stars 229 forks source link

Don't filter out parameters named 'args' or 'kwd' in utils.get_signature(). #173

Closed ian-r-rose closed 6 years ago

ian-r-rose commented 6 years ago

Fixes #172.

Uses inspect.getfullargspec instead of inspect.signature. This makes it closer to the python 2 version of the same function, and hopefully more maintainable.

inspect.getfullargspec had previously been deprecated in favor of inspect.signature, but that deprecation has been reversed in order to maintain better compatibility with Python 2/3 codebases.

fonnesbeck commented 6 years ago

Thanks. That's much more elegant.