Only cast pandas Series or DataFrame to numpy if dtype is not 'O'.

pymc-devs / pymc2

THIS IS THE **OLD** PYMC PROJECT (VERSION 2). PLEASE USE PYMC INSTEAD:

http://pymc-devs.github.com/pymc/

Other

879 stars 229 forks source link

Only cast pandas Series or DataFrame to numpy if dtype is not 'O'. #60

Closed twiecki closed 8 years ago

twiecki commented 8 years ago

'O' has before been a pass-through dtype that allowed users to pass in values that were not strictly numpy arrays. HDDM for example passed in pandas DataFrames which it then expected in the likelihood. With commit 7c7be9a52581bc666411fbc42420e997d71e34cc HDDM broke. With these changes, it works again.

fonnesbeck commented 8 years ago

Looks fine to me. Merging.

twiecki commented 8 years ago

Thanks @fonnesbeck. Can we cut a new release so that hddm users can upgrade?

fonnesbeck commented 8 years ago

Eek. I just released 2.3.5 a couple weeks ago. Okay, I will see how soon I can get 2.3.6 out.

twiecki commented 8 years ago

I know... but it's breaking all of HDDM.

fonnesbeck commented 8 years ago

OK, 2.3.6 is released.

twiecki commented 8 years ago

Thank you @fonnesbeck!