pymc-devs / pymc4

Experimental PyMC interface for TensorFlow Probability. Official work on this project has been discontinued.
Apache License 2.0
713 stars 113 forks source link

Add support for LocalLinearTrend and Seasonal #322

Closed kori73 closed 3 years ago

kori73 commented 3 years ago

I would like to work on adding a few time-series distributions starting with LocalLinearTrend and Seasonal.

Looking at the discussions for the AR pull request, I see that you are not currently happy with the way the initial_state_prior for tfp is obtained. Currently, we are passing a MultivariateNormalDiag with initial_state mean and std close to 0.

I have checked how the initial_state_prior is used in the base class (LinearGaussianStateSpaceModel) and it seems that the covariance method needs to be implemented.

Do you have any suggestions on how to proceed?

fonnesbeck commented 3 years ago

@kori73 Thanks for your interest. The development team has made the decision not to continue with the TFP-based version of PyMC. We will instead be updating the Theano backend to make it compile with JAX and other engines. If you are interested in contributing to PyMC, I'd suggest directing your attention to the PyMC3 repo, as it will continue to the main supported version of PyMC.