search

pymc-devs / pymcon_web_series_website

http://www.pymcon.com
5 stars 11 forks source link

Add links to videos for events past #110

Closed reshamas closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for pymcon ready!

Name Link
Latest commit a2d9a6aeb7bd8daa965649be50287f5b33f5a0c2
Latest deploy log https://app.netlify.com/sites/pymcon/deploys/6428420dc29880000886f263
Deploy Preview https://deploy-preview-110--pymcon.netlify.app/events
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cluhmann commented 1 year ago

This is great. Two things. First, I think the text "Discourse Post" is going to be confusing because many people don't know what "Discourse" (the platform) is. Maybe something like "Details" instead? Second, the links are a bit squished together on browser, so that it doesn't look like 3 separate "buttons". Is there any way to get some horizontal separation between them?

image

canyon289 commented 1 year ago

Echoing what Christian said

reshamas commented 1 year ago

First, I think the text "Discourse Post" is going to be confusing because many people don't know what "Discourse" (the platform) is. Maybe something like "Details" instead?

Previously it was "Learn more". I am not sure it is an issue if people have not heard of Discourse. As a user, if I hadn't heard of Discourse, I would click on the link anyway to see where it led me.

Second, the links are a bit squished together on browser, so that it doesn't look like 3 separate "buttons". Is there any way to get some horizontal separation between them?

I agree the buttons need a bit of spacing. I did try a few things but couldn't figure it out. I don't have the experience to add a space. I would probably accept as is and open an issue for style preference.