pymc-devs / pymcon_web_series_website

http://www.pymcon.com
5 stars 11 forks source link

Sponsor: add ODSC logo to pymcon web series website #121

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

Towards:

netlify[bot] commented 1 year ago

Deploy Preview for pymcon ready!

Name Link
Latest commit 8631b600a4b9d8d91847ca1e7ab5caa4bcf18ad8
Latest deploy log https://app.netlify.com/sites/pymcon/deploys/64868e9020e2e80008beb116
Deploy Preview https://deploy-preview-121--pymcon.netlify.app/sponsors
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

reshamas commented 1 year ago

@purna135 Not sure what to do with the different size logo (Mistplay vs ODSC).

Other logos for ODSC are here: https://github.com/pymc-devs/brand/tree/main/sponsors/sponsor_logos/odsc

Preview here: https://deploy-preview-121--pymcon.netlify.app/sponsors/

Screenshot 2023-06-11 at 4 02 23 PM
canyon289 commented 1 year ago

The images should edited so theyre the same height and width. @purna135 this might be scope creep for you though, if this is too much let us know and we'll find folks to help

purna135 commented 1 year ago

@reshamas Please check https://deploy-preview-121--pymcon.netlify.app/sponsors/

reshamas commented 1 year ago

@reshamas Please check https://deploy-preview-121--pymcon.netlify.app/sponsors/

Thank you @purna135

reshamas commented 1 year ago

@purna135 You changed the name of the mistplay logo here.

Unfortunately, it broke the logo link here, since the pymcon website logo links to here: https://www.pymc.io/welcome.html

purna135 commented 1 year ago

Oops, I didn't notice that, let me fix it now.

purna135 commented 1 year ago

But as I can see here the ODSC logo links to brand repo https://github.com/pymc-devs/pymc.io/blob/a864e27e89e1715753eb174d67eda04f03b0e00c/welcome.md?plain=1#L124-L127

reshamas commented 1 year ago

@purna135 the ODSC logo is fine. it's the Mistplay logo that is broken.

purna135 commented 1 year ago

opening a PR soon

reshamas commented 1 year ago

@purna135 You may want to link it to this logo here: for welcome.md page https://github.com/pymc-devs/brand/blob/main/sponsors/sponsor_logos/mistplay2_white.png

purna135 commented 1 year ago

Yes, I'm doing the same, but I've noticed, other imgs are also breaking; any ideas why? I can fix them all in one PR.

image image
reshamas commented 1 year ago

@purna135 Can you check this page in a new browser? https://www.pymc.io/welcome.html#sponsors

For me, only mistplay logo is broken.

purna135 commented 1 year ago

I have checked in Chrome, Opera and Edge and getting the same result as below:

image

image

reshamas commented 1 year ago

Can you share the URL of the page?

purna135 commented 1 year ago

https://www.pymc.io/welcome.html#sponsors

reshamas commented 1 year ago

my view is

Screenshot 2023-06-19 at 11 57 40 AM
purna135 commented 1 year ago

I checked from my phone and everything was good, let me restart my PC : )

purna135 commented 1 year ago

@reshamas please have a look, https://github.com/pymc-devs/pymc.io/pull/89

purna135 commented 1 year ago

my view is

A restart fixed my issue now I getting the same view