pymc-devs / pymcon_web_series_website

http://www.pymcon.com
5 stars 11 forks source link

social media icons are not viewable #13

Closed reshamas closed 1 year ago

reshamas commented 2 years ago

colors style needs to be updated

Screen Shot 2022-10-24 at 2 08 03 PM
purna135 commented 2 years ago

Yes, there are some other places also where the background color obscures the content; we need to change this color.

purna135 commented 2 years ago

Hi @cuchoi, could you help me in defining the colour theme? We are using the colour code you provided here, but we need more colour to make the website look better.

In comparison to the previous colour scheme, some sections of the website are not visible due to the background colour, which we should fix.

Please take a look at both versions of the sites.

CC: @canyon289, @mjhajharia what's your thought on this?

I am attaching some screenshots

cuchoi commented 2 years ago

Are colors configured globally or you can choose them for specific sections?

If they can be selected by section, my proposal would be the following (let me know if they make sense to you):

If it can't be selected by section, can you point to where the colors are defined? To check how many colors are needed and see if we can come up with a solution with what we currently have.

purna135 commented 2 years ago

Thank you, @cuchoi. I will experiment with the color you suggested above and give an update.

Are colors configured globally or you can choose them for specific sections?

Yes, the colors are set globally as shown below, and we use these color variables in every section. but we can select a different color for each section. https://github.com/pymc-devs/pymcon_2022_website/blob/481511928dfecb78b662f49585e7034b94b6499b/static/css/main.css#L10-L22