search

pymc-devs / pymcon_web_series_website

http://www.pymcon.com
5 stars 11 forks source link

Add link straight to an event in the events page #134

Closed purna135 closed 9 months ago

purna135 commented 9 months ago

Fixes #118 Each event now has a unique ID and a button that allows you to copy the link to that specific event.

netlify[bot] commented 9 months ago

Deploy Preview for pymcon ready!

Name Link
Latest commit c563dca6d7ec9862eab308d241ffe9d5f3e60f65
Latest deploy log https://app.netlify.com/sites/pymcon/deploys/653264efc89e9b00089a1d42
Deploy Preview https://deploy-preview-134--pymcon.netlify.app/events
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

canyon289 commented 9 months ago

I think its better to leave the button not disabled in case someone wants to copy again, the check mark looks great. Having the link is quite nice!

purna135 commented 9 months ago

I think its better to leave the button not disabled in case someone wants to copy again

done

We can keep two types of links:

  1. pycom.com/event/#eventNumber (e.g., pycom.com/event/# 8)
  2. pycom.com/event/#eventTitle (e.g., pycom.com/event/#automatic-probability-with-pymc)

Which of these options do you prefer?

canyon289 commented 9 months ago

Hey sorry I missed this, Title is better,

purna135 commented 9 months ago

Title is better,

done ✅, please have a look

canyon289 commented 9 months ago

LGTM!