pymc-devs / pymcon_web_series_website

http://www.pymcon.com
5 stars 11 forks source link

brief skeleton for events page #58

Closed mjhajharia closed 1 year ago

mjhajharia commented 1 year ago

check #57

This mostly resembles the organizers page structure and only has preliminary structure

Please drop any ideas about layout changes:

cc: @canyon289 @purna135 @cluhmann

purna135 commented 1 year ago

Can you share a preview/screensort of the current changes?

Maybe we can add the card we made for the website's initial edition. which can be found here, https://purna135.github.io/pymcon-hugo/

image

canyon289 commented 1 year ago

Can you share a preview/screensort of the current changes?

Maybe we can add the card we made for the website's initial edition. which can be found here, https://purna135.github.io/pymcon-hugo/

image

Using this card is an amazing idea! It has all the elements we need. Curious how it matches up to the card in this PR.

canyon289 commented 1 year ago

This is a good start. Thanks for adding the page and a configurable toml

Two questions

image

canyon289 commented 1 year ago

Bigger screenshot for reference

image

purna135 commented 1 year ago

Using this card is an amazing idea! It has all the elements we need. Curious how it matches up to the card in this PR.

We already have this card; I recall commenting these lines of code when we made the website public.

See PR, https://github.com/pymc-devs/pymcon_web_series/pull/152

I believe we can enable it and create a separate page for events.

purna135 commented 1 year ago

Can we blend what you have with what @purna135 has on his card?

If you prefer, I can uncomment the code for this card and create a separate page for the event. Because I already designed this card, it will take me less time.

reshamas commented 1 year ago

@purna135 Do you think we can choose a size for the card that is consistent with the Meetup size? Such as 1200 by 630 px?

purna135 commented 1 year ago

Are you referring to this card? Yes, we can absolutely choose this size.

image

reshamas commented 1 year ago

@purna135 Yes, this one, which shows the social card.

Screen Shot 2022-12-19 at 12 40 47 PM
purna135 commented 1 year ago

Hi @mjhajharia, will you apply the changes mentioned above to this PR?

Or should I create a new PR for this?

cluhmann commented 1 year ago

Is there anything we can do to help this along? We have the rough event schedule confirmed, so we can begin filling in the skeleton with actual content relatively quickly after this is merged.

purna135 commented 1 year ago

Let me open another PR that incorporates the above-mentioned changes.

mjhajharia commented 1 year ago

hi! sorry for the long silence, I wasn't sure what was required because the .toml I added had all the attributes in the incoming_talks file and a few more. Anyway, I incorporated that card into the website as well. So now, you can simply add true or false to highlighted as an atttribute in events.toml to mark an event (for viewing it on the home page). Otherwise, it stays the same on the events page.

Here are (zoomed out) previews for the home page (featured events) as well as the events page.

image image

Let me know if this works!

netlify[bot] commented 1 year ago

Deploy Preview for pymcon ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/pymcon/deploys/63b8d8f6cc26af2e5dda63d3
Deploy Preview https://deploy-preview-58--pymcon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

canyon289 commented 1 year ago

Other event page is merged so closing this one. Thanks @mjhajharia for your contributions as well