pymc-devs / pymcon_web_series_website

http://www.pymcon.com
5 stars 11 forks source link

Event page: update speaker cards #75

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

Closes #69

netlify[bot] commented 1 year ago

Deploy Preview for pymcon ready!

Name Link
Latest commit 8ada225d77ae3c73d1cdfaaa5b4be9d7d891e9b1
Latest deploy log https://app.netlify.com/sites/pymcon/deploys/63e7f01a74bdf600089a51bc
Deploy Preview https://deploy-preview-75--pymcon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

canyon289 commented 1 year ago

thank you for all these updates. One question regarding the images. Are they supposed to look like this or is the github svg renderer making things look strange?

image
reshamas commented 1 year ago

Not sure, the previews look ok here: https://deploy-preview-75--pymcon.netlify.app/events/

reshamas commented 1 year ago

@canyon289 The SVG files look ok to me: https://github.com/pymc-devs/pymcon_web_series_website/pull/75/files?file-filters%5B%5D=.svg&show-viewed-files=true

Are you checking on mobile?

canyon289 commented 1 year ago

Huh..... Im on my macbook. In those same link I'm still seeing issues as well. Would it be safer to use jpgs or pngs to avoid local rendering issues like this one

image image image
canyon289 commented 1 year ago

🎉 🎉