search

pymc-devs / pytensor

PyTensor allows you to define, optimize, and efficiently evaluate mathematical expressions involving multi-dimensional arrays.
https://pytensor.readthedocs.io
Other
300 stars 91 forks source link

Flaky `tests/tensor/rewriting/test_linalg.py::test_local_lift_through_linalg[kron-pinv-batched]` #755

Open ricardoV94 opened 2 months ago

ricardoV94 commented 2 months ago

Description

Failed once here: https://github.com/pymc-devs/pytensor/actions/runs/8988371565/job/24689101034?pr=744#step:6:3856

CC @jessegrabowski

jessegrabowski commented 2 months ago

this was flakey when I wrote the test so I brought the tolerance way way down and I guess it's still not enough. It might be good to think of a different approach for testing linalg functions with lots of numbers, because it seems like just "generate some random values and compare" is error prone for larger matrices