pymc-labs / CausalPy

A Python package for causal inference in quasi-experimental settings
https://causalpy.readthedocs.io
Apache License 2.0
914 stars 65 forks source link

Add logo to readthedocs and add favicon #245

Closed jpreszler closed 1 year ago

jpreszler commented 1 year ago

This resolves issue #237 .

I'm using the same image for the favicon, which looks ok according to http://www.colinkeany.com/favicon-checker/, but in general I think the logo isn't the best on dark themed browsers, so it may be worth having a specialized favicon version of the logo that looks good at the small size in all themes.

Screenshot 2023-09-19 at 1 00 51 PM
codecov[bot] commented 1 year ago

Codecov Report

Merging #245 (01e566d) into main (28d50b9) will not change coverage. Report is 8 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files          19       19           
  Lines        1149     1149           
=======================================
  Hits          849      849           
  Misses        300      300           
jpreszler commented 1 year ago

I took a stab at a specialized favicon that is a bit more distinctive in browser tabs (especially dark themed). I've added a white background, extracted the rocket and dag parts, and done some color and sharpness adjustments to help the contrast.

Screenshot 2023-09-21 at 9 45 46 AM
jpreszler commented 1 year ago

@drbenvincent this is ready when you get a chance.

drbenvincent commented 1 year ago

Nice! Sorry for the delay - I've had some newborn parenting challenges. I'll merge this and see how things go. We can always iterate on the logo or light/dark theme if needed, but this looks good already.