search

pymc-labs / CausalPy

A Python package for causal inference in quasi-experimental settings
https://causalpy.readthedocs.io
Apache License 2.0
914 stars 65 forks source link

check `Makefile` now that we use ruff #271

Closed drbenvincent closed 12 months ago

drbenvincent commented 1 year ago

In #268, @juanitorduz brought in use of ruff for formatting and linting.

I'm wondering if we need to make any edits here in the listing related parts of the Makefile

https://github.com/pymc-labs/CausalPy/blob/2169bf0b310c29187c957bd128c8774a46ab5138/Makefile#L6-L18

jsakv commented 12 months ago

@drbenvincent I went through the PR steps and the makefile also need to be updated.

I have started to have a look, I will raise a PR soon!

drbenvincent commented 12 months ago

Fantastic @jsakv :)

juanitorduz commented 12 months ago

@jsakv we have one something similar for PyMC Marketing https://github.com/pymc-labs/pymc-marketing/pull/438 :)