User specified number of significant figures for numbers in plots

drbenvincent commented 10 months ago

Closes #266.

The core functions (round_num and _format_sig_figs) are taken from the Arviz repo.

Tests are included.

I've re-run selected notebooks

review-notebook-app[bot] commented 10 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

juanitorduz commented 10 months ago

LGTM but there is a doc-test failing ¯\(ツ)/¯

drbenvincent commented 9 months ago

Remote failing tests should hopefully be fixed whenever https://github.com/pymc-devs/pytensor/pull/550 is fixed and make its way into a new pytensor release. Or when https://github.com/pymc-labs/CausalPy/issues/279 is resolved. So don't sink any effort into trying to fix failing remote tests right now. You can of course ensure that all local tests pass - they are not affected by the issue. Not on my machine anyway.

drbenvincent commented 9 months ago

Well this is frustrating. Remote tests still not passing.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (fc28a3b) 75.86% compared to head (198bde6) 76.27%.

Files	Patch %	Lines
causalpy/pymc_experiments.py	63.15%	7 Missing :warning:
causalpy/skl_experiments.py	55.55%	4 Missing :warning:
causalpy/utils.py	90.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #272 +/- ## ========================================== + Coverage 75.86% 76.27% +0.41% ========================================== Files 20 20 Lines 1305 1332 +27 ========================================== + Hits 990 1016 +26 - Misses 315 316 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pymc-labs / CausalPy

User specified number of significant figures for numbers in plots #272

Codecov Report