search

pymc-labs / CausalPy

A Python package for causal inference in quasi-experimental settings
https://causalpy.readthedocs.io
Apache License 2.0
914 stars 65 forks source link

changed splitting behaviour for PrePostFit #275

Closed rlaker closed 11 months ago

rlaker commented 12 months ago

Fix for #273

drbenvincent commented 11 months ago

Thanks very much for this @rlaker! Just letting you know that this is on my list. Things are hectic but I will be able to request changes or approve/merge in the first few days of Dec. So around the end of this week.

drbenvincent commented 11 months ago

Sorry for the delay on this @rlaker. I think this is good to merge. We just have a failing test. Tests pass for me locally, so it could perhaps be a version issue, or sometimes remote tests randomly just fail. I'll try to trigger those tests again and see what happens.

drbenvincent commented 11 months ago

Remote failing tests should hopefully be fixed whenever https://github.com/pymc-devs/pytensor/pull/550 is fixed and make its way into a new pytensor release. Or when https://github.com/pymc-labs/CausalPy/issues/279 is resolved. So don't sink any effort into trying to fix failing remote tests right now. You can of course ensure that all local tests pass - they are not affected by the issue. Not on my machine anyway.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c17fcf2) 75.86% compared to head (0c3f23d) 75.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #275 +/- ## ======================================= Coverage 75.86% 75.86% ======================================= Files 20 20 Lines 1305 1305 ======================================= Hits 990 990 Misses 315 315 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.