search

pymc-labs / CausalPy

A Python package for causal inference in quasi-experimental settings
https://causalpy.readthedocs.io
Apache License 2.0
914 stars 65 forks source link

Add docs on justifying instruments in the IV approach #345

Closed NathanielF closed 5 months ago

NathanielF commented 5 months ago

Just a draft PR for the moment.

Pretty happy with the example. Need to add some more write up and discuss if we want to add JAX/Numpyro as a dependency to the package.

NathanielF commented 5 months ago

Hid code and expanded explanation

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Done.

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Added more signposting

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Checked headers

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Yep. Added

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Added a one-liner

View entire conversation on ReviewNB

NathanielF commented 5 months ago

yep, removed.

View entire conversation on ReviewNB

NathanielF commented 5 months ago

added!

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Hid code

View entire conversation on ReviewNB

NathanielF commented 5 months ago

I wasn't sure about changing the DAG here. I'm not sure it adds more as it's still the NEAR variable just adding more species of college... I think it's fine without a specific DAG.

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Added in the detail

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Adjusted

View entire conversation on ReviewNB

NathanielF commented 5 months ago

Updated

View entire conversation on ReviewNB

review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

drbenvincent commented on 2024-06-18T11:09:46Z ----------------------------------------------------------------

duplicated word "interest interest"


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

drbenvincent commented on 2024-06-18T11:09:47Z ----------------------------------------------------------------

Great. Can you also add in a link "replication crisis" as a specific term simply because I've just heard that much more than credibility revolution. Link: https://en.wikipedia.org/wiki/Replication_crisis


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

drbenvincent commented on 2024-06-18T11:09:48Z ----------------------------------------------------------------

Thanks for adding LATE to the glossary. Can you add in the glossary link to the first mention of LATE please?


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

drbenvincent commented on 2024-06-18T11:09:49Z ----------------------------------------------------------------

repetition of "at least"


drbenvincent commented 5 months ago

Really nice, much clearer I think. Just a few minor edits and it's ready to merge :)

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.