pymc-labs / CausalPy

A Python package for causal inference in quasi-experimental settings
https://causalpy.readthedocs.io
Apache License 2.0
880 stars 63 forks source link

Add page of causal video resources from PyMC community into the docs #379

Closed ParthJohri closed 3 months ago

ParthJohri commented 3 months ago

feat: Add causal videos from PyMC / PyMC Labs community Issue No: 374

closes #374

What type of PR:-

Description

  1. Added the causal_video_resources page markdown file for the PyMC Labs Videos, used iframe to add the videos.
  2. Tested if the UI is responsive or not in both light and dark mode.
  3. Updated the index.md for the knowledge base to include the page link for the causal_video_resources.

Screenshot & Screen recording

https://github.com/pymc-labs/CausalPy/assets/76129377/7305cb30-6a73-4c7c-a403-8c2e916219d6

link-check


📚 Documentation preview 📚: https://causalpy--379.org.readthedocs.build/en/379/

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.60%. Comparing base (2ac74e5) to head (2154428). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ======================================= Coverage 85.60% 85.60% ======================================= Files 22 22 Lines 1716 1716 ======================================= Hits 1469 1469 Misses 247 247 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ParthJohri commented 3 months ago

@drbenvincent , I made the following changes, please let me know if any other change has to be made.

Changes

Screenshots

change1 change2 change3 change4

drbenvincent commented 3 months ago

Excellent. Very minor thing, but can we change What if Causal reasoning meets Bayesian Inference to What if? Causal reasoning meets Bayesian Inference. Then we are good to merge :)

ParthJohri commented 3 months ago

@drbenvincent I have made the title change, let me know if any other change has to be made?

change5

drbenvincent commented 3 months ago

Thanks very much for your first contribution @ParthJohri!

If you have time, if relevant, I'd be interested to hear about any pain points in the process of contributing. For example, could the CONTRIBUTING doc be clearer etc, or did you run into any issues setting up the dev environment?

I'll slightly modify the PR title simply because that it what will appear in the auto generated release notes.

Thanks again!

ParthJohri commented 3 months ago

Thanks very much for your first contribution @ParthJohri!

If you have time, if relevant, I'd be interested to hear about any pain points in the process of contributing. For example, could the CONTRIBUTING doc be clearer etc, or did you run into any issues setting up the dev environment?

I'll slightly modify the PR title simply because that it what will appear in the auto generated release notes.

Thanks again!

No, the CONTRIBUTING doc was pretty descriptive, I did come across some issues, for example I was getting some errors with mamba so used conda for setting up the dev environment, and after it, I was able to complete the task without any problems.