`michaelis_menten` transformation as `pt.TensorVariable`

[PabloRoque]

Make michaelis_meten consistent with the rest of SaturationTransformation by wrapping it as pt.TensorVariable

Description

• Rename old michaelis_menten as michaelis_menten_function. Made to avoid major changes in mmm.utils.estimate_menten_parameters's L70.
• Wrap previous michaelis_menten_function as pt.TensorVariable inside michaelis_menten
• Minor change in test_michaelis_menten. The TensorVariable now needs to be evaluated.
• Minor changes to type hints
• Wrap MichaelisMentenSaturation.functionwith pt.as_tensor_variable
• Expand test_plotting.mock_mmm fixture with MichaelisMentenSaturation
• .eval() in example notebook

Related Issue

• [x] Closes #1050
• [ ] Related to #

Checklist

• [ ] Checked that the pre-commit linting/style checks pass
• [x] Included tests that prove the fix is effective or that the new feature works
• [ ] Added necessary documentation (docstrings and/or example notebooks)
• [ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected

• [x] MMM
• [ ] CLV

Type of change

• [ ] New feature / enhancement
• [x] Bug fix
• [ ] Documentation
• [ ] Maintenance
• [ ] Other (please specify):

---

📚 Documentation preview 📚: https://pymc-marketing--1054.org.readthedocs.build/en/1054/

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[wd60622]

I am looking over the _plot_response_curve_fit internals. I think it would be better to rely on the SaturationTransformation.sample_curve method so that the solution doesn't directly call the function method.

There needs to be a solution that works for others custom saturation transformations

I will create an issue for this. We can address in the future #1056

[PabloRoque]

Can you write a test for the case that discovered this bug

Added saturation fixture. Now test_mmm_plots includes MichaelisMentenSaturation. Would fail without TensorVariable in plot_direct_contribution_curves fixture, but does not with the fix in this PR (pending suggested changes)

[PabloRoque]

SaturationTransformation.sample_curve

This will add 3 extra pm.Deterministic to the model. Are we happy we that behavior?

[wd60622]

This will add 3 extra pm.Deterministic to the model.

Are we happy we that behavior?

Lets skip if that is required. Dont think that would be good

[wd60622]

Thanks for all the edits @PabloRoque

I am out atm but @juanitorduz will take a look

[juanitorduz]

I'll review on the weekend 🙏💪 (busy week ahead 😄)

[PabloRoque]

No rush! I'll be taking some time off myself until the 28th.