Open jsnyde0 opened 1 week ago
@juanitorduz this is my very first contribution to someone else's open-source project. I've created a draft PR here: https://github.com/pymc-labs/pymc-marketing/pull/1058
I went through all the checklists. One test failed but I don't see how that's related?
FAILED tests/test_mlflow.py::test_autolog_pymc_model[numpyro] - ModuleNotFoundError: No module named 'jax.linear_util'
Some considerations I had myself:
original_scale
, but should we pass posterior_predictive_data
directly instead of handling scaling within each function?posterior predictive data
? Would this justify passing it explicitly as an argument?Is that a local failure? Or in the CI?
Local failure, seems like the test passed in the CI
See this discussion
Goal is to extend the current function of plot_posterior_predictive with backward compatibility using individual private functions:
This allows to add some plotting options like adding the mean or a gradient representation of the full posterior predictive distribution to
plot_posterior_predictive
as follows: