#1057 - Expanded plotting options of plot_posterior_predictive - Githubissues

pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.

https://www.pymc-marketing.io/

Apache License 2.0

705 stars 198 forks source link

#1057 - Expanded plotting options of plot_posterior_predictive #1058

Closed jsnyde0 closed 1 month ago

jsnyde0 commented 1 month ago

Description

The `plot_posterior_predictive' function has gotten new plotting options. Depending on the parameters, it can also show:

HDI (Highest Density Intervals) at 94% and 50% levels (as before)
Mean prediction line (new)
Gradient representation of the full posterior distribution (new)

The new function argument related to this are:

add_hdi : bool, optional - If True, add highest density intervals to the plot. Default is True.
add_mean : bool, optional - If True, add the mean prediction to the plot. Default is True.
add_gradient : bool, optional - If True, add a gradient representation of the full posterior distribution. Default is False.

A new example notebook is added to demonstrate: mmm_plotting_options.ipynb

Related Issue

[x] Closes #1057
[ ] Related to #

Checklist

[x] Checked that the pre-commit linting/style checks pass
[x] Included tests that prove the fix is effective or that the new feature works
[x] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected

[x] MMM
[ ] CLV

Type of change

[x] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1058.org.readthedocs.build/en/1058/

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

juanitorduz commented 1 month ago

Thanks @jsnyde0 . Can you please add additional tests in https://github.com/pymc-labs/pymc-marketing/blob/1a1703c5f34045548f43754179982cd98128beb0/tests/mmm/test_plotting.py#L137-L164

:)

jsnyde0 commented 1 month ago

@juanitorduz done!

Also, I messed up the commit history so I made a new branch & PR: https://github.com/pymc-labs/pymc-marketing/pull/1066

wd60622 commented 1 month ago

@juanitorduz done!

Also, I messed up the commit history so I made a new branch & PR: https://github.com/pymc-labs/pymc-marketing/pull/1066

Feel free to close the pr that is now stale