search

pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.
https://www.pymc-marketing.io/
Apache License 2.0
683 stars 190 forks source link

PyMC test helper function missing #189

Closed juanitorduz closed 1 year ago

juanitorduz commented 1 year ago

When looking into https://github.com/pymc-labs/pymc-marketing/pull/186 I saw that a job is failing because:

_______________ ERROR collecting tests/clv/test_distributions.py _______________
ImportError while importing test module '/home/runner/work/pymc-marketing/pymc-marketing/tests/clv/test_distributions.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.10.10/x64/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/clv/test_distributions.py:7: in <module>
    from pymc.tests.helpers import select_by_precision
E   ModuleNotFoundError: No module named 'pymc.tests'

Can this be related to https://github.com/pymc-devs/pymc/pull/6540 @ricardoV94 ?

ricardoV94 commented 1 year ago

Yes, we are porting the utilities back to pymc.tests so that they can be used by downstream packages

michaelraczycki commented 1 year ago

could you give a bit more insight about this? I could take care of that

ricardoV94 commented 1 year ago

@michaelraczycki I think I'll take care of it now as it is a problem in multiple libraries we have.

Just because of the urgency