pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.
https://www.pymc-marketing.io/
Apache License 2.0
676 stars 185 forks source link

Doc formatting is broken in various places/ways #367

Open cluhmann opened 1 year ago

cluhmann commented 1 year ago

The list of methods for the MMM module is squashed horizontally. Many methods have long names, but I am not sure this is the problem. I am viewing on a desktop with a widescreen, so I don't think it's a resolution/aspect ratio issue either. Here is a screenshot of the delayed_saturated_mmm module found here:

image

In addition, some of the MMM methods have docstrings that I suspect are incorrectly formatted. Here is an example of the documentation of the channel_contributions_forward_pass() method. The return values are formatted correctly, but the arguments (channel_data) are not:

image

The same problems occur with get_channel_contributions_forward_pass_grid().

wd60622 commented 1 year ago

Yes, I've noticed this too in a spots. Usually fixed by adding a space the docstring in order to separate the sections better. There might be a way to check and/or format automatically

OriolAbril commented 9 months ago

Sphinx prints a lot of warnings when building the docs. They are about that and indicate where are blank lines or indents missing mostly.

wd60622 commented 4 months ago

Running list:

BaseMMM

MMM

The ones from above plus some more

wd60622 commented 3 weeks ago

@juanitorduz You may have hit many of these when doing the ruff checks