Example NB plots are compressed

pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.

https://www.pymc-marketing.io/

Apache License 2.0

719 stars 205 forks source link

Example NB plots are compressed #666

Open twiecki opened 7 months ago

twiecki commented 7 months ago

https://www.pymc-marketing.io/en/stable/notebooks/mmm/mmm_lift_test.html

wd60622 commented 7 months ago

noticed that too ☹️

ColtAllen commented 7 months ago

This is also impacting the CLV notebooks. I tried changing the fig size in the plotting code, but it made no difference. I'm thinking we need to specify something in conf.py related to pydata-sphinx-theme.

twiecki commented 7 months ago

Maybe @OriolAbril has an idea.

juanitorduz commented 7 months ago

can it be related to https://github.com/executablebooks/MyST-NB/pull/588?

juanitorduz commented 7 months ago

mmmm when I build the docs locally make html it works with myst_nb == 1.0 so, when the PR above has not merged ...

juanitorduz commented 7 months ago

Here is a quick fix https://github.com/pymc-labs/pymc-marketing/pull/667 . We might need a better solution. I think one has to tweak the nb_cell_metadata_key, but I did not manage to do it :(

juanitorduz commented 7 months ago

I will re-open this issue as the fix in https://github.com/pymc-labs/pymc-marketing/pull/667 should not be final as we do not want to restrict the versions :)