Should unit tests live outside of the package?

pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.

https://www.pymc-marketing.io/

Apache License 2.0

683 stars 190 forks source link

Should unit tests live outside of the package? #79

Closed lucianopaz closed 1 year ago

lucianopaz commented 1 year ago

We are shipping our the tests folder inside of the pymmmc package. I don't think is is necessary or desirable. I propose that we move the tests folder to the root directory instead.

Current organization: root/ └─> pymmmc/ └─> tests/

Proposed: root/ ├─> pymmmc/ └─> tests/

ricardoV94 commented 1 year ago

No objections

drbenvincent commented 1 year ago

Agree. I believe this means that the tests are not packaged up into the pypi build, which is good.

Probably want a clear split (with folders?) between mmm and clv tests.

ricardoV94 commented 1 year ago

Closed by #116 (there was a typo)