search

pymc-labs / pymc-marketing

Bayesian marketing toolbox in PyMC. Media Mix (MMM), customer lifetime value (CLV), buy-till-you-die (BTYD) models and more.
https://www.pymc-marketing.io/
Apache License 2.0
717 stars 201 forks source link

Time Varying Media not considered in `channel_contributions_forward_pass` #819

Open wd60622 opened 4 months ago

wd60622 commented 4 months ago

The time varying contributions are not multiplied out in the method.

Having the time_varying forward pass method might be the way to go

Reference: https://github.com/pymc-labs/pymc-marketing/blob/a97e272de174aa32859c858fe62bb192b8262b45/pymc_marketing/mmm/delayed_saturated_mmm.py#L544-L548

juanitorduz commented 4 months ago

Shall we add this to the 0.8.0 milestone?

juanitorduz commented 1 day ago

@wd60622 Do you want to take a stab at this one, as https://github.com/pymc-labs/pymc-marketing/pull/998 seems forgotten?