search

pymeasure / leco-protocol

Design notes for a generic communication protocol to control experiments and measurement hardware
https://leco-laboratory-experiment-control-protocol.readthedocs.io
MIT License
6 stars 3 forks source link

Add Node concept and start network structure page. #24

Closed bilderbuchi closed 1 year ago

bilderbuchi commented 1 year ago

Closes #19, #36, #37.

It shows that defining one concept (Nodes) drags in a couple of others that need to defined, too. Feedback, please!

bilderbuchi commented 1 year ago

@bklebel what do you think? If you're ok with this, you can merge.

bklebel commented 1 year ago

One more comment on this: You people are amazingly crazy fast. It's a pleasure to work with you!

bilderbuchi commented 1 year ago

One more comment on this: You people are amazingly crazy fast. It's a pleasure to work with you!

Thanks! ❤️ Yesterday afternoon was quite intense, I was just constantly working off Github notifications from incoming comments on my comments. We should really schedule a video call in our matrix room...

bilderbuchi commented 1 year ago

🥳

I thought the use of "closes" in the PR description would pick that up, but apparently not (you have to repeat the verb).