search

pymeasure / leco-protocol

Design notes for a generic communication protocol to control experiments and measurement hardware
https://leco-laboratory-experiment-control-protocol.readthedocs.io
MIT License
6 stars 3 forks source link

Component names printable ASCII only? #47

Closed bilderbuchi closed 1 year ago

bilderbuchi commented 1 year ago

In #38, we decided that

A Component name must be a series of ASCII characters, without the character "."

_Originally posted by @bilderbuchi in https://github.com/pymeasure/leco-protocol/pull/38#discussion_r1106333828_

To avoid shenanigans with escape sequences or whatnot, I would prefer to restrict this to the printable ASCII range except ., i.e. 0x20 to 0x7E, excluding 0x2E.

Thoughts?

BenediktBurger commented 1 year ago

I'm fine with it.

I don't see any good reason, why someone could neet a carriage return or new line etc as a Charakter in a name.