pymeasure / leco-protocol

Design notes for a generic communication protocol to control experiments and measurement hardware
https://leco-laboratory-experiment-control-protocol.readthedocs.io
MIT License
6 stars 3 forks source link

Refusal of duplicate namespace added. #52

Closed BenediktBurger closed 1 year ago

BenediktBurger commented 1 year ago

During my implementation I found a bug, which requires some more specification in the protocol:

If a Coordinator (N1) is already connected to another one (N2), no third one might sign in as N2 as well.

This is kind of obvious, should be stated though (similar to Components).

bilderbuchi commented 1 year ago

LGTM! Do we need to account for the case where a Component/Coordinator fell off the network and is reconnecting (with the same name as before, presumably), or is that covered already elsewhere?

BenediktBurger commented 1 year ago

They have to wait, until their name is cleared due to expired heartbeats as we do not have any possibility to state "hey, I'm the replacement for that dead connection."