pymeasure / pyleco

Python implementation of the Laboratory Experiment COntrol (LECO) protocol
MIT License
9 stars 3 forks source link

Improve communicator and director #44

Closed BenediktBurger closed 7 months ago

BenediktBurger commented 7 months ago

The interpret_rpc_response of the CommunicatorProtocol and the read_rpc_response of the Director are quality of life improvements, which skip the step of calling objects of other objects.

Additionally removal of some older code.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1dc6662) 86.46% compared to head (baf378e) 86.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## ========================================== + Coverage 86.46% 86.47% +0.01% ========================================== Files 32 32 Lines 2579 2581 +2 Branches 312 312 ========================================== + Hits 2230 2232 +2 - Misses 289 290 +1 + Partials 60 59 -1 ``` | [Flag](https://app.codecov.io/gh/pymeasure/pyleco/pull/44/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pymeasure/pyleco/pull/44/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | `86.47% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.