pymeasure / pyleco

Python implementation of the Laboratory Experiment COntrol (LECO) protocol
MIT License
9 stars 3 forks source link

Fix DataLogger to start a timer, even if not specified explicitly. #51

Closed BenediktBurger closed 7 months ago

BenediktBurger commented 7 months ago

The DataLogger did not start a new timer, if it is not specified explicitly.

A test verifies the behavior and passes with this fix.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a39db7) 87.03% compared to head (8f338f4) 87.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 87.03% 87.05% +0.01% ========================================== Files 33 33 Lines 2538 2541 +3 Branches 300 303 +3 ========================================== + Hits 2209 2212 +3 Misses 274 274 Partials 55 55 ``` | [Flag](https://app.codecov.io/gh/pymeasure/pyleco/pull/51/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pymeasure/pyleco/pull/51/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | `87.05% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.