codecov[bot]
commented
6 months ago Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (
97a0d1b) 87.26% compared to head (1e6d6ef) 87.02%.
| Files | Patch % | Lines |
|---|---|---|
| pyleco/utils/qt_listener.py | 4.00% | 24 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================== - Coverage 87.26% 87.02% -0.25% ========================================== Files 33 33 Lines 2560 2589 +29 Branches 303 303 ========================================== + Hits 2234 2253 +19 - Misses 272 282 +10 Partials 54 54 ``` | [Flag](https://app.codecov.io/gh/pymeasure/pyleco/pull/55/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pymeasure/pyleco/pull/55/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | `87.02% <60.65%> (-0.25%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A bug in the BaseCommunicator prevented the message handler from receiving not signed in messages and other error messages.
This PR fixes the communication.